This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 3/5 v3] Darwin: set startup-with-shell to off on Sierra and later.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Xavier Roirand <roirand at adacore dot com>
- Cc: gdb-patches at sourceware dot org, simon dot marchi at polymtl dot ca, tom at tromey dot com
- Date: Mon, 10 Sep 2018 08:25:59 +0100
- Subject: Re: [RFA 3/5 v3] Darwin: set startup-with-shell to off on Sierra and later.
- References: <1536491553-9311-1-git-send-email-roirand@adacore.com>
> gdb/ChangeLog:
>
> * darwin-nat.c (should_disable_startup_with_shell):
> New function.
> (darwin_nat_target::create_inferior): Add call.
One minor nit:
> + gdb::optional<scoped_restore_tmpl<int>> restore_startup_with_shell;
> +
> + if (startup_with_shell && should_disable_startup_with_shell ())
> + {
> + warning (_("startup-with-shell not supported on this macOS version, disabling it."));
Can you split this line to fit in 80 characters, please?
--
Joel