This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2, doc] python: Provide textual representation for Inferior and Objfile


On 2018-09-13 10:36, Tom Tromey wrote:
"Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

Simon> +gdb_test "python print (inferiors)" "\\(<gdb.Inferior num=1,
pid=$decimal>,\\)" "verify inferiors list"

Some of the new test lines run over 80 characters.

Most of them are easy enough to make fit in 80 chars, but one is still over, because it has a long match pattern string. My understanding was that we were a bit more lenient on the line length for those gdb_test lines (splitting the patterns just to comply to that rule would just make them less readable).

Other than that nit the patch looks good to me.

Thanks, I pushed it with those fixed as much as I can. I also addressed Eli's comment about repr() and str().

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]