This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix crash with empty Rust enum

From: Tom Tromey <tom at tromey dot com>
To: Tom Tromey <tom at tromey dot com>
Cc: Simon Marchi <simon dot marchi at polymtl dot ca>, gdb-patches at sourceware dot org
Date: Thu, 13 Sep 2018 10:49:40 -0600
Subject: Re: [PATCH] Fix crash with empty Rust enum
References: <20180911213659.10366-1-tom@tromey.com> <2532514a403b7979fcd4ff915a644b95@polymtl.ca> <87va7ai6ba.fsf@tromey.com>

>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:

Tom> Maybe I could change rust_enum_variant so that the callers can do this.
Tom> I'll look.

I looked and I think I will keep it as is.
The existing errors refer to variants, like:

		  error(_("Cannot access field %d of variant %s::%s, "
			  "there are only %d fields"),

This seems nicely specific, so it's worth preserving; but on the other
hand, in the new scenario, there are no variants, so mentioning the
variant does not make sense.

However I am making the other change you suggested, and I found another
buglet besides which I will tack on.

Tom

References:
- [PATCH] Fix crash with empty Rust enum
  - From: Tom Tromey
- Re: [PATCH] Fix crash with empty Rust enum
  - From: Simon Marchi
- Re: [PATCH] Fix crash with empty Rust enum
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]