This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] Logical short circuiting with argument lists
- From: Tom Tromey <tom at tromey dot com>
- To: Richard Bunt <richard dot bunt at arm dot com>
- Cc: gdb-patches at sourceware dot org, nd at arm dot com
- Date: Fri, 14 Sep 2018 15:00:37 -0600
- Subject: Re: [PATCH v3] Logical short circuiting with argument lists
- References: <833f15b2-48da-fe83-86c8-3c2bce46b01c@arm.com>
>>>>> "Richard" == Richard Bunt <richard.bunt@arm.com> writes:
Richard> Version 3 addresses review comments:
Richard> * Removed forward declaration of skip_undetermined_arglist.
Richard> * Made definition of skip_undetermined_arglist static.
Richard> * Added introductory comment to skip_undetermined_arglist.
Richard> * Dropped (*pos)+=3 into the block.
Richard> * Adjusted Tcl bracing.
Richard> * Removed string splitting in the test case.
Thanks again for the patch.
Richard> + if (noside != EVAL_SKIP)
Richard> + {
Richard> + return evaluate_var_value (noside, exp->elts[pc + 1].block, var);
Richard> + }
The gdb style is no braces if there's just a single line.
Richard> + else
Richard> + {
Richard> + /* Return a dummy value of the correct type when skipping, so
Richard> + that parent functions know what is to be skipped. */
Richard> + return allocate_value (SYMBOL_TYPE (var));
... compared to here, where braces are mandatory.
This patch is ok with that first set of braces removed.
(You don't have to re-send it.)
thanks,
Tom