This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/4] Change pspace_to_pspace_object to return a new reference

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simark at simark dot ca>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Sun, 16 Sep 2018 06:59:51 -0600
Subject: Re: [PATCH 1/4] Change pspace_to_pspace_object to return a new reference
References: <20180913053007.11780-1-tom@tromey.com> <20180913053007.11780-2-tom@tromey.com> <cf078c2a-85b2-ca0b-f65f-36c5ae0220c5@simark.ca> <d8ef1ee0-d81c-add6-51f3-874d93a8b9d7@simark.ca>

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> Ah ok, this is the code I added recently, that's why.  I think changing it to
Simon>   return pspace_to_pspace_object (pspace).release ();
Simon> should work.

Yep, I got this on rebasing and did what you suggest here.

Tom

References:
- [PATCH 0/4] Disallow the return of borrowed references
  - From: Tom Tromey
- [PATCH 1/4] Change pspace_to_pspace_object to return a new reference
  - From: Tom Tromey
- Re: [PATCH 1/4] Change pspace_to_pspace_object to return a new reference
  - From: Simon Marchi
- Re: [PATCH 1/4] Change pspace_to_pspace_object to return a new reference
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]