This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/4] Change thread_to_thread_object to return a new reference

From: Tom Tromey <tom at tromey dot com>
To: Tom Tromey <tom at tromey dot com>
Cc: Simon Marchi <simark at simark dot ca>, gdb-patches at sourceware dot org
Date: Sun, 16 Sep 2018 09:35:34 -0600
Subject: Re: [PATCH 3/4] Change thread_to_thread_object to return a new reference
References: <20180913053007.11780-1-tom@tromey.com> <20180913053007.11780-4-tom@tromey.com> <38dedd0d-1f03-eb7d-84a6-15cdc29e8ea2@simark.ca> <875zz5pmg8.fsf@tromey.com>

>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:

Tom> I think it is best to have a single style - returning NULL should also
Tom> set the Python exception.

Maybe the gdbpy_ref (1-argument) constructor and release methods could
assert that the Python exception is set if the underlying pointer is
NULL.  That would not get full checking but maybe it would catch some
problems.  And maybe we should simply use gdbpy_ref in many more places
in the Python layer -- ideally, reserve raw pointers solely for
parameters which are borrowed references.

Tom

References:
- [PATCH 0/4] Disallow the return of borrowed references
  - From: Tom Tromey
- [PATCH 3/4] Change thread_to_thread_object to return a new reference
  - From: Tom Tromey
- Re: [PATCH 3/4] Change thread_to_thread_object to return a new reference
  - From: Simon Marchi
- Re: [PATCH 3/4] Change thread_to_thread_object to return a new reference
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]