This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] compile: Remove non-const reference parameters
- From: Keith Seitz <keiths at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 17 Sep 2018 06:29:13 -0700
- Subject: Re: [PATCH] compile: Remove non-const reference parameters
- References: <1535647635-9566-1-git-send-email-simon.marchi@ericsson.com> <874leoocso.fsf@tromey.com>
On 09/16/2018 11:31 PM, Tom Tromey wrote:
> I think this particular change introduced a regression. runtest
> gdb.compile/*.exp causes gdb to crash for me several times on x86-64
> Fedora 28.
Fedora 28 is really broken right now. I have patches to fix almost
everything*, but I am struggling to understand why one of them is needed.
AFAICT, either __builtin_memcpy has usage changes that I missed, or there is
a glibc bug here. ["compile print" is completely broken -- the
__builtin_memcpy on Fedora 28 does nothing. Works fine on my Fedora 21
and 26 boxes.]
Using __builtin_memmove works fine, though. [And just to state the obvious,
no, the memory regions do not overlap.]
Keith
* "Everything" = everything except what appears to be a newly introduced GCC
8 bug that causes regressions in compile-cplus-method.exp.