This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] Remove munmap_listp_free_cleanup

From: Pedro Alves <palves at redhat dot com>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 18 Sep 2018 15:18:54 +0100
Subject: Re: [PATCH 1/2] Remove munmap_listp_free_cleanup
References: <20180915222411.24764-1-tom@tromey.com> <20180915222411.24764-2-tom@tromey.com> <9642b747-7f95-fe5d-4cf3-b0d623ec40ae@redhat.com> <87bm8vvmzv.fsf@tromey.com>

On 09/17/2018 10:21 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> I think we should wrap that in try/catch, because an infcall can be
> Pedro> aborted/throw, and we're in a destructor.
> 
> My latest version just ignores the exception.  It seemed to me that
> there isn't much the user can do about this, so a warning would be
> un-helpful.  If you agree, I'll push that.  Or, I could have it emit a
> warning if you think that's worthwhile.

I agree.

Thanks,
Pedro Alves

References:
- [PATCH 0/2] remove the remaining cleanups from gdb/compile
  - From: Tom Tromey
- [PATCH 1/2] Remove munmap_listp_free_cleanup
  - From: Tom Tromey
- Re: [PATCH 1/2] Remove munmap_listp_free_cleanup
  - From: Pedro Alves
- Re: [PATCH 1/2] Remove munmap_listp_free_cleanup
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]