This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Mark more file descriptors close-on-exec
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 19 Sep 2018 08:30:09 -0700
- Subject: Re: [PATCH] Mark more file descriptors close-on-exec
- References: <20180918224747.6396-1-tom@tromey.com>
Hi Tom,
On Tue, Sep 18, 2018 at 04:47:47PM -0600, Tom Tromey wrote:
> I noticed a couple of spots in gdb that were opening files but not
> marking the file descriptors as close-on-exec. This patch fixes
> these.
>
> There are still a few more of these, but they are in code that I can't
> compile, so I'd prefer not to touch.
>
> gdb/ChangeLog
> 2018-09-18 Tom Tromey <tom@tromey.com>
>
> * ctf.c (ctf_start): Use gdb_fopen_cloexec.
> * common/scoped_mmap.c (mmap_file): Use gdb_open_cloexec.
Thanks for the patch, Tom. It looks good to me.
Which other locations did you notice that you couldn't compile?
--
Joel