This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Provide pid_to_exec_file on Solaris (PR tdep/17903)
Hi Joel,
>> 2018-06-13 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
>>
>> PR tdep/17903
>> * procfs.c (procfs_target): Declare pid_to_exec_file.
>> (procfs_target::pid_to_exec_file): New.
>
> Nice :). This is OK for me as is; one question: Have you considered
> the use of an std::string for the variable "name"? I thought about it,
> and I'm not sure it would make the code all that better, but thought
> I'd mention it again, in case you or someone else sees something
> I don't see.
TBH, I know close to nothing about C++, so rely on others for
suggestions here.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University