This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Provide pid_to_exec_file on Solaris (PR tdep/17903)
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 19 Sep 2018 19:47:19 +0200
- Subject: Re: [PATCH] Provide pid_to_exec_file on Solaris (PR tdep/17903)
- References: <ydd4lelh8q2.fsf@CeBiTec.Uni-Bielefeld.DE> <87bm8tr19q.fsf@tromey.com>
Hi Tom,
> Rainer> + scoped_fd fd (open (name, O_RDONLY));
>
> You may wish to use gdb_open_cloexec.
I'll give it a whirl and change the patch accordingly before committing
if it works out.
> procfs.c is one of the cloexec holdouts, because I could never compile it.
> But I guess once the buildbot is up I can do it :)
Certainly: my proposed buildbot patch adds them to the try_ssh scheduler
to allow just that. In the meantime, you may well send procfs patches
my way if you like ;-)
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University