This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Provide Solaris 11 buildbots
On Monday, September 24 2018, I wrote:
> On Monday, September 24 2018, Rainer Orth wrote:
>> it seems we managed to mess up the configure flags badly here: right now
>> the buildbots are configured with just CFLAGS/CXXFLAGS=-m64, nothing
>> more. I hope the following patch should fix things:
>
> Ah, OK. I may have misunderstood the patch/requirements. I've now
> simplified the configuration.
>
>> * There's no need for disable_default_compilation_flags = True: the
>> default works just fine, we only need to add -O at the moment. Isn't
>> it enough to do this once in RunTestGDBSolaris_Common?
>
> Yeah, it should be.
>
>> * Obviously the -m64 needs to be appended in RunTestGDBPlainSolaris_c64
>> to both CFLAGS and CXXFLAGS to avoid losing the -O above.
>
> Yeah.
>
>> * Not in the patch, but wouldn't it be enough to set enable_targets_all,
>> make_command, and run_testsuite only once in RunTestGDBSolaris_Common?
>
> It turned out to be a bit more complicated. I'm in a hurry right now,
> so I did a quick hack to make it work. I'll monitor the next builds.
After this, the builds started to pass. Thanks for bringing this to my
attention, Rainer.
I'll enable the email notifications for both builders later today.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/