This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] testsuite: fix is_amd64_regs_target


On 2018-09-28 01:20 PM, Tom Tromey wrote:
>>>>>> "Markus" == Metzger, Markus T <markus.t.metzger@intel.com> writes:
> 
> Markus> That's my assumption, as well.  We already checked the architecture so we know it
> Markus> is some x86 flavor.  A single 64-bit register should suffice.
> 
> I didn't see it go in, so I wanted to reiterate that I think it is ok.
> 
> Tom
> 

Maybe I'm missing something obvious, but could one of you explain to me
the comment of that proc, which is

# Return 1 if target has x86_64 registers - either amd64 or x32.
# x32 target identifies as x86_64-*-linux*, therefore it cannot be determined
# just from the target string.

If I understand correctly, is_amd64_regs_target should return 1 when using the
x32 abi, as well as when using the standard amd64 abi.  The comment says an x32
target has an x86_64-* triplet... so can't we just check the triplet, and return
1 if it's x86-64-*?

Simon

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]