This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 2/4] Use the existing instruction to determine the RISC-V breakpoint kind.

From: John Baldwin <jhb at FreeBSD dot org>
To: Andrew Burgess <andrew dot burgess at embecosm dot com>
Cc: gdb-patches at sourceware dot org, jimw at sifive dot com
Date: Fri, 28 Sep 2018 14:16:14 -0700
Subject: Re: [PATCH v2 2/4] Use the existing instruction to determine the RISC-V breakpoint kind.
References: <20180924205151.22217-1-jhb@FreeBSD.org> <20180924205151.22217-3-jhb@FreeBSD.org> <20180928102304.GT5952@embecosm.com>

On 9/28/18 3:23 AM, Andrew Burgess wrote:
> While you're editing these lines could you remove the trailing
> whitespace please, so '\n\' instead of '\n \', the latter doesn't seem
> to be the norm in GDB doc strings.
> 
> Feel free to switch 'read_code' as Simon suggested.
> 
> Otherwise this is fine to commit.

Ok, I've pushed it with both of these fixes applied.

-- 
John Baldwin

References:
- [PATCH v2 0/4] Initial support for FreeBSD/riscv
  - From: John Baldwin
- [PATCH v2 2/4] Use the existing instruction to determine the RISC-V breakpoint kind.
  - From: John Baldwin
- Re: [PATCH v2 2/4] Use the existing instruction to determine the RISC-V breakpoint kind.
  - From: Andrew Burgess

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]