This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 5/6] Do not reopen temporary files
- From: Tom Tromey <tom at tromey dot com>
- To: Simon Marchi <simark at simark dot ca>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Mon, 01 Oct 2018 03:14:54 -0600
- Subject: Re: [RFC 5/6] Do not reopen temporary files
- References: <20180926111130.18956-1-tom@tromey.com> <20180926111130.18956-6-tom@tromey.com> <ef37ad49-a1bd-93fd-1766-10cee8a00108@simark.ca>
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> + /* Order matters here; we want FILE to be closed before FILENAME_TEMP is
>> + unlinked, because on MS-Windows one cannot delete a file that is
>> + still open. (Don't call anything here that might throw until
>> + file_closer is created.) So, we wrap the unlinker in an optional
Simon> I just noticed this refers to file_closer, a variable that doesn't exist anymore
Simon> (or has been renamed).
Thanks. I've removed the parenthesized sentence, because it no longer
applies.
Tom