This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Record ARM THUMB2 PLD/PLI cache instructions
On 10/03/2018 01:34 AM, Trent Piepho wrote:
> Sorry, not that motivated. I wanted to make reverse debugging work on
> ARM, and it works for me now. Don't really want to dive into adding
> more to the self tests, which I've never used. There's really no call
> to do that on company time anyway, while for reverse debugging there
> was.
Those tests in question _are_ about reverse debugging, and adding
tests can be considered (and often required) part of a patch.
arm_record_test doesn't cover many instructions today because when
record support was added, we didn't have the self testing
infrastructure in place yet. See:
https://sourceware.org/ml/gdb-patches/2017-03/msg00031.html
Can't tell whether adding self tests for these instructions would
be really useful, but if you ever want to try it, it's quite easy
to trigger those tests -- type "maint selftest arm-record" in gdb.
Thanks,
Pedro Alves