This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Avoid crash when calling warning too early
- From: Tom Tromey <tom at tromey dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Sat, 06 Oct 2018 15:13:08 -0600
- Subject: Re: [RFC] Avoid crash when calling warning too early
- References: <20181006192007.1945-1-tom@tromey.com> <87woquq3b7.fsf@redhat.com>
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> The patch looks good to me. My only question is about whether we still
Sergio> require a newline between variable declarations and the rest of the
Sergio> code. I still follow this rule (because I think it improves code
Sergio> readability), but now with C++11 I'm not sure if it's still being
Sergio> enforced.
I don't know, but I suppose so, and in any case I went ahead and added
it.
Tom