This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Testsuite: Remove race condition from mi-cmd-param-changed.exp
- From: Pedro Alves <palves at redhat dot com>
- To: Alan Hayward <alan dot hayward at arm dot com>, gdb-patches at sourceware dot org
- Cc: nd at arm dot com, Tom de Vries <tdevries at suse dot de>
- Date: Tue, 9 Oct 2018 14:00:10 +0100
- Subject: Re: [PATCH] Testsuite: Remove race condition from mi-cmd-param-changed.exp
- References: <20181009124457.81037-1-alan.hayward@arm.com>
On 10/09/2018 01:44 PM, Alan Hayward wrote:
> target_supports_scheduler_locking does not wait for the gdb
> prompt after calling gdb_start_cmd.
>
> Fix by replacing with runto_main.
>
> This removes the racy behaviour of mi-cmd-param-changed.exp.
>
> gdb/testsuite/ChangeLog:
>
> 2018-10-09 Alan Hayward <alan.hayward@arm.com>
>
> * lib/gdb.exp (target_supports_scheduler_locking): Call runto_main.
Tom de Vries had already submitted a patch for this, but it
hadn't been reviewed yet. I've approved Tom's now. Sorry
about the duplicated work.
Thanks,
Pedro Alves