This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] Fix resource leak found by Coverity

From: Tom Tromey <tom at tromey dot com>
To: Gary Benson <gbenson at redhat dot com>
Cc: gdb-patches at sourceware dot org
Date: Wed, 10 Oct 2018 10:02:12 -0600
Subject: Re: [PATCH 1/2] Fix resource leak found by Coverity
References: <1539176277-4500-1-git-send-email-gbenson@redhat.com> <1539176277-4500-2-git-send-email-gbenson@redhat.com>

>>>>> "Gary" == Gary Benson <gbenson@redhat.com> writes:

Gary> This commit fixes a resource leak found by Coverity, where cli_interp's
Gary> constructor creates a new cli_ui_out, but there was no corresponding
Gary> destructor to free it.

Same deal with the patch title.

Gary> 	* cli/cli-interp.c (cli_interp::~cli_interp): New function.

I wonder if it's possible for the ui-out to be used after the
interpreter is destroyed.  A simple check with valgrind would show that,
I think.

This is ok if that succeeds.

Tom

References:
- [PATCH 0/2] Fix resource leaks found by Coverity
  - From: Gary Benson
- [PATCH 1/2] Fix resource leak found by Coverity
  - From: Gary Benson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]