This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Upper case test names


On 2018-10-17 03:30, Tom de Vries wrote:
[ was: Re: [PATCH][gdb/testsuite] Rewrite catch-follow-exec.exp ]

On 10/16/18 12:11 AM, Simon Marchi wrote:
Please use a lower case letter for the test name.

Hmm, that happens more often, appearantly:
...
find gdb/testsuite/ -type f -name "*.exp" | grep -v /lib/ | xargs egrep
$'[\t ](fail|pass|unsupported|untested|xfail|kfail) "[A-Z][a-z]' | egrep
-v 'PowerPC|Rust'
gdb/testsuite/gdb.ada/bp_inlined_func.exp:   fail "Cannot run to main,
testcase aborted"
gdb/testsuite/gdb.ada/excep_handle.exp:   fail "Cannot run to main,
testcase aborted"
gdb/testsuite/gdb.ada/mi_string_access.exp:   fail "Cannot run to main,
testcase aborted"
gdb/testsuite/gdb.ada/mi_var_union.exp:   fail "Cannot run to main,
testcase aborted"
gdb/testsuite/gdb.arch/arc-analyze-prologue.exp: fail "Can't run to main"
gdb/testsuite/gdb.arch/arc-decode-insn.exp:    fail "Can't run to main"
gdb/testsuite/gdb.base/readnever.exp:    untested "Couldn't compile
${srcfile}"
gdb/testsuite/gdb.fortran/printing-types.exp: untested "Could not run
to breakpoint MAIN__"
gdb/testsuite/gdb.guile/scm-lazy-string.exp: fail "Can't run to main"
...

Does this need fixing?

Sure, it would need fixing, if you want to take the time to do it. Here's the reference in our wiki where that rule is stated, for reference.

https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Follow_the_test_name_convention

Thanks,

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]