This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][gdb] fix unsigned overflow in charset.c


On 10/17/2018 07:47 PM, Paul Koning wrote:
> 
> 
>> On Oct 17, 2018, at 2:38 PM, John Baldwin <jhb@FreeBSD.org> wrote:
>>
>>> ...
>>> From an aesthetic perspective, "ssize_t" seems better, as the "obvious
>>> signed version of size_t".  From a pedantic perspective, ptrdiff_t
>>> sounds better.
>>
>> Ok, I think ssize_t is probably fine, so I Think Paul's original patch is
>> ok?
>>
>> -- 
>> John Baldwin
> 
> Please let me know; I can commit that patch if it is approved.  Or commit with changes if that's desired.

Patch is OK as is.  Please push.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]