This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [OBV/PUSHED][PATCH] testsuite: ovldbreak.exp: fix regexp


> On 19 Oct 2018, at 15:17, Pedro Alves <palves@redhat.com> wrote:
> 
> On 10/19/2018 11:12 AM, Alan Hayward wrote:
>> Fix the layout used in the regexp for breakpoints.
>> 
>> Fixes two FAILS.
>> 
> 
> Curious, it doesn't fail for me.  What changed?

Two things:

Info breakpoint - the gaps between the fields. Some parts of the regexp
was just checking for 5 spaces, some parts were checking spaces+tabs.
It was also inconsistent throughout the .exp file - the exact same gaps
are checked differently. Made sure they were all spaces+tab checks.

On both x86 and aarch64, for the breakpoint at main, I get line 48 - the
“{“, instead of line 49, the first actual line of code. Allowed it to
have either. Maybe better fix would be to lookup the line number.


Alan.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]