Re: [OBV/PUSHED][PATCH] testsuite: ovldbreak.exp: fix regexp

[Pedro Alves <palves at redhat dot com>]

On 10/19/2018 05:03 PM, Alan Hayward wrote:
> 
> 
>> On 19 Oct 2018, at 16:42, Pedro Alves <palves@redhat.com> wrote:
>>
>> On 10/19/2018 04:21 PM, Alan Hayward wrote:
>>>
>>>> On 19 Oct 2018, at 15:17, Pedro Alves <palves@redhat.com> wrote:
>>>>
>>>> On 10/19/2018 11:12 AM, Alan Hayward wrote:
>>>>> Fix the layout used in the regexp for breakpoints.
>>>>>
>>>>> Fixes two FAILS.
>>>>>
>>>>
>>>> Curious, it doesn't fail for me.  What changed?
>>>
>>> Two things:
>>>
>>> Info breakpoint - the gaps between the fields. Some parts of the regexp
>>> was just checking for 5 spaces, some parts were checking spaces+tabs.
>>> It was also inconsistent throughout the .exp file - the exact same gaps
>>> are checked differently. Made sure they were all spaces+tab checks.
>>
>> OK.
>>
>>> On both x86 and aarch64, for the breakpoint at main, I get line 48 - the
>>> “{“, instead of line 49, the first actual line of code. Allowed it to
>>> have either. Maybe better fix would be to lookup the line number.
>>
>> It's rare to see that these days, especially at -O0.
>> That might be some regression.  What compiler was that?
>>
> 
> Would that be a bug in GDB or the compiler?

Impossible to say off hand.  Could be either.

> 
> My setups are:
> 
> Aarch64 Ubuntu 16.04:
> gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
> 
> X86 Ubuntu 16.04:
> gcc (Ubuntu 7.2.0-1ubuntu1~16.04) 7.2.0
> 
> 
> I just tried it without my patch on 
> 
> Aarch64 Opensuse13.3 with
> gcc (SUSE Linux) 7.2.1 20171020 [gcc-7-branch revision 253932]
> 
> Aarch64 centos7.4 with
> gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
> 
> It passes on both of those. Looks like it could be an Ubuntu
> issue then?

Ubuntu's gcc has some local changes, and enables some gcc options
by default that aren't enabled elsewhere.  So it could also be that
GDB is mishandling something that isn't well tested elsewhere.

Thanks,
Pedro Alves