This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: Handle ICC's unexpected void return type
- From: Kevin Buettner <kevinb at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Andrew Burgess <andrew dot burgess at embecosm dot com>
- Date: Wed, 24 Oct 2018 10:10:44 -0700
- Subject: Re: [PATCH] gdb: Handle ICC's unexpected void return type
- References: <20181023212843.4774-1-andrew.burgess@embecosm.com>
Hi Andrew,
Mostly okay, just a two nits...
On Tue, 23 Oct 2018 22:28:43 +0100
Andrew Burgess <andrew.burgess@embecosm.com> wrote:
> diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
> index 2a1b805c9a7..7d9026a59d7 100644
> --- a/gdb/dwarf2read.c
> +++ b/gdb/dwarf2read.c
> @@ -551,6 +551,7 @@ struct dwarf2_cu
> unsigned int checked_producer : 1;
> unsigned int producer_is_gxx_lt_4_6 : 1;
> unsigned int producer_is_gcc_lt_4_3 : 1;
> + unsigned int producer_is_icc : 1;
Use bool here like the recently added producer_is_codewarrior.
And...
> @@ -25134,6 +25155,7 @@ dwarf2_cu::dwarf2_cu (struct dwarf2_per_cu_data *per_cu_)
> checked_producer (0),
> producer_is_gxx_lt_4_6 (0),
> producer_is_gcc_lt_4_3 (0),
> + producer_is_icc (0),
Use false instead of 0.
Kevin