This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 0/2] Return gdbpy_ref in a couple more places

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Andrew Burgess <andrew dot burgess at embecosm dot com>
Cc: gdb-patches at sourceware dot org
Date: Wed, 24 Oct 2018 16:03:01 -0400
Subject: Re: [PATCH 0/2] Return gdbpy_ref in a couple more places
References: <cover.1540407540.git.andrew.burgess@embecosm.com>

On 2018-10-24 15:12, Andrew Burgess wrote:

I spotted a couple of places where a gdbpy_ref was released in one
function only to be recreated again later.

Thanks,
Andrew

Thanks, both patches LGTM. However, please update the commit titles toinclude the function name (e.g. "gdb/python: Make cmdpy_completer_helperreturn gdbpy_ref<>"). It's clearer than having multiple commits withthe same title.


Simon

References:
- [PATCH 0/2] Return gdbpy_ref in a couple more places
  - From: Andrew Burgess

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]