This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/5] RISC-V: Add native linux support.
- From: Pedro Alves <palves at redhat dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, Andreas Schwab <schwab at suse dot de>
- Cc: Jim Wilson <jimw at sifive dot com>, gdb-patches at sourceware dot org
- Date: Thu, 25 Oct 2018 13:06:25 +0100
- Subject: Re: [PATCH 4/5] RISC-V: Add native linux support.
- References: <CAFyWVaZoF3a=-QjADoUdzq_hz5skHVaxmXtB1X5ZT-a_sns5PA@mail.gmail.com> <20180808233908.8149-1-jimw@sifive.com> <mvm8t2mpahm.fsf@suse.de> <20181025110946.GN2929@embecosm.com>
On 10/25/2018 12:09 PM, Andrew Burgess wrote:
>
> I removed the extra { ... } block in line with the coding standard
> while editing this area.
Actually, this applies here:
> Any two or more lines in code should be wrapped in braces, even if they are comments, as they look like separate statements:
> if (i)
> {
> /* Return success. */
> return 0;
> }
>
> and not:
>
> if (i)
> /* Return success. */
> return 0;
From:
https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards?highlight=%28coding%29%7C%28conventions%29#Whitespaces
Thanks,
Pedro Alves