This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] RISC-V: Linux signal frame support.


On Thu, 25 Oct 2018 16:59:35 -0700
Jim Wilson <jimw@sifive.com> wrote:

> Make riscv_isa_flen available to the linux native code, and clean up duplicate
> comments.
> 
> 	gdb/
> 	* riscv-tdep.c (riscv_isa_xlen): Refer to riscv-tdep.h comment.
> 	(riscv_isa_flen): Likewise.  Drop static.
> 	* riscv-tdep.h (riscv_isa_xlen): Move riscv-tdep.c comment to here.
> 	(riscv_isa_flen): Likewise.

Maybe:

	(riscv_isa_flen): Likewise; declare.

?

Otherwise, LGTM.

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]