This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] RISC-V: Linux signal frame support.

From: Jim Wilson <jimw at sifive dot com>
To: kevinb at redhat dot com
Cc: gdb-patches at sourceware dot org
Date: Fri, 26 Oct 2018 10:34:19 -0700
Subject: Re: [PATCH 1/2] RISC-V: Linux signal frame support.
References: <CAFyWVaYFSWGfC_idDngHGd6fMKO8n2hohzdXWXcBh0MoqCqfTA@mail.gmail.com> <20181025235935.3781-1-jimw@sifive.com> <20181025202529.5b52880e@pinnacle.lan>

On Thu, Oct 25, 2018 at 8:25 PM Kevin Buettner <kevinb@redhat.com> wrote:
>
> On Thu, 25 Oct 2018 16:59:35 -0700
> Jim Wilson <jimw@sifive.com> wrote:
>
> > Make riscv_isa_flen available to the linux native code, and clean up duplicate
> > comments.
> >
> >       gdb/
> >       * riscv-tdep.c (riscv_isa_xlen): Refer to riscv-tdep.h comment.
> >       (riscv_isa_flen): Likewise.  Drop static.
> >       * riscv-tdep.h (riscv_isa_xlen): Move riscv-tdep.c comment to here.
> >       (riscv_isa_flen): Likewise.
>
> Maybe:
>
>         (riscv_isa_flen): Likewise; declare.
>
> ?
>
> Otherwise, LGTM.

Thanks.  Committed with the corrected ChangeLog entry.

Jim

References:
- [PATCH 0/2] RISC-V: Linux signal frame support.
  - From: Jim Wilson
- [PATCH 1/2] RISC-V: Linux signal frame support.
  - From: Jim Wilson
- Re: [PATCH 1/2] RISC-V: Linux signal frame support.
  - From: Kevin Buettner

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]