This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 1/6] Unify shell-finding logic

From: Tom Tromey <tom at tromey dot com>
To: Sergio Durigan Junior <sergiodj at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Sat, 27 Oct 2018 11:41:34 -0600
Subject: Re: [PATCH v2 1/6] Unify shell-finding logic
References: <20181018223100.20693-1-tom@tromey.com> <20181018223100.20693-2-tom@tromey.com> <87tvlhv7o3.fsf@redhat.com>

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> Not sure if I reviewed this one before, but it LGTM (with a very small
Sergio> nit below).  It also can be pushed independently, IMO.

>> +/* Return the file name of the user's shell.  */

Sergio> WDYT about explicitly mentioning here that "user's shell" means "the
Sergio> SHELL environment variable"?

I added some text here.

Tom

References:
- [PATCH v2 0/6] A different approach to startup-with-shell on macOS
  - From: Tom Tromey
- [PATCH v2 1/6] Unify shell-finding logic
  - From: Tom Tromey
- Re: [PATCH v2 1/6] Unify shell-finding logic
  - From: Sergio Durigan Junior

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]