This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] gdb: Handle ICC's unexpected void return type

From: Kevin Buettner <kevinb at redhat dot com>
To: Andrew Burgess <andrew dot burgess at embecosm dot com>
Cc: Keith Seitz <keiths at redhat dot com>, gdb-patches at sourceware dot org
Date: Tue, 30 Oct 2018 20:26:04 -0700
Subject: Re: [PATCH] gdb: Handle ICC's unexpected void return type
References: <20181023212843.4774-1-andrew.burgess@embecosm.com> <0794714d-b2f8-6175-cc98-6000d77ea933@redhat.com> <20181031002259.GM15098@embecosm.com> <af6bbbf0-15b2-fd5c-fcd4-a81ebd962c00@redhat.com>

On Tue, 30 Oct 2018 17:34:00 -0700
Keith Seitz <keiths@redhat.com> wrote:

> > The new patch moves the conversion from integer type to void type into
> > a new function which is now called from a couple of places, but all
> > from within dwarf2read.c:read_base_type, this catches the return type
> > and the variable type issues.  The test has been renamed to remove the
> > focus on return type.  Otherwise, everything is pretty similar.
> > 
> > Let me know what you think.  
> 
> That answers all the questions I had. Thank you very much.
> 
> Kevin has already approved the patch, so unless he has anything further,
> I would say this patch is good to go in.

I read through the new patch.  It looks good to me also.

Kevin

References:
- [PATCH] gdb: Handle ICC's unexpected void return type
  - From: Andrew Burgess
- Re: [PATCH] gdb: Handle ICC's unexpected void return type
  - From: Keith Seitz
- Re: [PATCH] gdb: Handle ICC's unexpected void return type
  - From: Andrew Burgess
- Re: [PATCH] gdb: Handle ICC's unexpected void return type
  - From: Keith Seitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]