This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Regression on old kernels (Re: [PATCH v5 00/12] GDB support for more powerpc registers on linux)


Ulrich Weigand <uweigand@de.ibm.com> writes:

>> gdb/gdbserver/ChangeLog:
>> YYYY-MM-DD  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
>> 
>> 	* linux-ppc-low.c: Include nat/linux-ptrace.h.
>
> This is probably unnecessary; linux-ppc-low.c already includes
> linux-low.h which in turn includes nat/linux-ptrace.h

Ah I didn't notice that.  However, the wiki says I shouldn't use
definitions by indirect inclusion, and linux-low.c itself includes both
headers.  Should I still remove this?

Thanks!

--
Pedro Franco de Carvalho


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]