This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: Handle ICC's unexpected void return type
- From: Tom Tromey <tom at tromey dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 06 Nov 2018 11:10:57 -0700
- Subject: Re: [PATCH] gdb: Handle ICC's unexpected void return type
- References: <20181023212843.4774-1-andrew.burgess@embecosm.com>
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> I encountered a binary compiled with Intel's C Compiler version
Andrew> 14.0.5.212, which seemed to contain some non-standard DWARF.
[...]
Andrew> A test confirms that the issue is fixed.
Thanks for this test. It's very good to have these; in the past I think
some compiler workarounds have gone in without such tests, and then
later it is difficult to figure out whether changes keep gdb working.
Andrew> + if (bits == 0 && producer_is_icc (cu)
Andrew> + && strcmp (name, "void") == 0)
I think NAME can be null here, so an additional check is needed to avoid
a potential crash.
Tom