This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][gdb/symtab] Fix language of duplicate static minimal symbol
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: Tom de Vries <tdevries at suse dot de>
- Cc: Keith Seitz <keiths at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 07 Nov 2018 10:48:48 -0500
- Subject: Re: [PATCH][gdb/symtab] Fix language of duplicate static minimal symbol
- References: <20181030191142.GA13785@delia> <07e42727-0d74-7f04-ef7c-39e180f71da8@redhat.com> <b5867027-cc84-47fe-353e-6bbbb0ce96ea@suse.de> <eedb5703619d1beb390f2b1404556c1d@polymtl.ca>
On 2018-11-07 10:23, Simon Marchi wrote:
On 2018-10-31 05:09, Tom de Vries wrote:
I have a pre-commit script (for both gcc and gdb) that uses this
format,
and puts ChangeLog hunks in the correct ChangeLog file ( more detail
here: https://sourceware.org/ml/gdb-patches/2018-06/msg00351.html ).
Sofar this format has been acceptable for maintainers.
Yes, as long as they end up in the right file it's fine.
Keith made me look at the contribution checklist again, and it says:
"In your patch email you should also specify which changelog is being
modified."
I agree that for clarity, it's better to state in which ChangeLog each
snippet goes. It would be preferable to follow that.
Personally, in the patch email, I don't include the date/name/email for
ChangeLog entries that will bear my name, since it would be redundant.
And putting today's date would be meaningless, as I would update it
anyway to the current date when I push the patch. And I think putting
"YYYY-MM-DD" doesn't serve much purpose.
Simon