This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] RISC-V: gdb.base/gnu_vector fixes.
* Jim Wilson <jimw@sifive.com> [2018-11-06 13:44:28 -0800]:
> GCC gives vectors natural aligment based on total size, not element size,
> bounded by the maximum supported type alignment.
>
> gdb/
> * riscv-tdep.c (BIGGEST_ALIGNMENT): New.
> (riscv_type_alignment) <TYPE_CODE_ARRAY>: If TYPE_VECTOR, return min
> of TYPE_LENGTH and BIGGEST_ALIGNMENT.
As with patch #1, please update the patch title line.
> ---
> gdb/riscv-tdep.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c
> index ac4f2533f4..3d4f7e3dcc 100644
> --- a/gdb/riscv-tdep.c
> +++ b/gdb/riscv-tdep.c
> @@ -59,6 +59,9 @@
> /* The stack must be 16-byte aligned. */
> #define SP_ALIGNMENT 16
>
> +/* The biggest alignment that the target supports. */
> +#define BIGGEST_ALIGNMENT 16
> +
> /* Forward declarations. */
> static bool riscv_has_feature (struct gdbarch *gdbarch, char feature);
>
> @@ -1640,6 +1643,10 @@ riscv_type_alignment (struct type *t)
> return TYPE_LENGTH (t);
>
> case TYPE_CODE_ARRAY:
> + if (TYPE_VECTOR (t))
> + return std::min (TYPE_LENGTH (t), (unsigned)BIGGEST_ALIGNMENT);
I think there's supposed to be a space after the cast, '(unsigned) BIGGEST_ALIGNMENT'.
> + /* FALLTHROUGH */
> +
> case TYPE_CODE_COMPLEX:
> return riscv_type_alignment (TYPE_TARGET_TYPE (t));
>
> --
> 2.17.1
>
Otherwise, look fine.
Thanks,
Andrew