This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix buffer overflow in ada-lang.c:move_bits

From: Joel Brobecker <brobecker at adacore dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Fri, 9 Nov 2018 09:16:41 -0800
Subject: Re: [PATCH] Fix buffer overflow in ada-lang.c:move_bits
References: <20181024162037.21024-1-tom@tromey.com> <20181101153517.GA2705@adacore.com> <082f66ea-223b-52f4-bc24-b274dbcf4f01@redhat.com> <609409e6-235a-4724-3ced-57c3ff42e299@redhat.com>

> > I was going to suggest that this would benefit from unit tests in
> > the style of dwarf2read.c:copy_bitwise's, but, actually, isn't this
> > exactly the same as copy_bitwise?  Can we get rid of ada-lang.c:move_bits?
> > (And maybe move copy_bitwise elsewhere?)
> 
> I meant to say dwarf2loc.c instead of dwarf2read.c.

It does look exactly the same, doesn't it? I'll see if we can just
re-use dwarf2loc's copy_bitwise. Thanks for the suggestion!

-- 
Joel

Follow-Ups:
- Re: [PATCH] Fix buffer overflow in ada-lang.c:move_bits
  - From: Joel Brobecker

References:
- Re: [PATCH] Fix buffer overflow in ada-lang.c:move_bits
  - From: Joel Brobecker
- Re: [PATCH] Fix buffer overflow in ada-lang.c:move_bits
  - From: Pedro Alves
- Re: [PATCH] Fix buffer overflow in ada-lang.c:move_bits
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]