Re: [RFA 2/2] Test case for 'info variables|functions' with minimal symbols.

[Simon Marchi <simon dot marchi at ericsson dot com>]

On 2018-10-30 5:23 p.m., Philippe Waroquiers wrote:
> 2018-10-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
> 
> 	* gdb.base/info_minsym.c: New file.
> 	* gdb.base/info_minsym.exp: New file.
> ---
>  gdb/testsuite/gdb.base/info_minsym.c   | 12 +++++++++
>  gdb/testsuite/gdb.base/info_minsym.exp | 37 ++++++++++++++++++++++++++
>  2 files changed, 49 insertions(+)
>  create mode 100644 gdb/testsuite/gdb.base/info_minsym.c
>  create mode 100644 gdb/testsuite/gdb.base/info_minsym.exp
> 
> diff --git a/gdb/testsuite/gdb.base/info_minsym.c b/gdb/testsuite/gdb.base/info_minsym.c
> new file mode 100644
> index 0000000000..e71ce7abf9
> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/info_minsym.c
> @@ -0,0 +1,12 @@
> +static int minsym_var;
> +
> +static int minsym_fun (void)
> +{
> +   minsym_var++;
> +}
> +
> +int
> +main (void)
> +{
> +  return minsym_fun ();
> +}

Please add a license header to this file.

> diff --git a/gdb/testsuite/gdb.base/info_minsym.exp b/gdb/testsuite/gdb.base/info_minsym.exp
> new file mode 100644
> index 0000000000..8ec98b6071
> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/info_minsym.exp
> @@ -0,0 +1,37 @@
> +# Copyright (C) 2018 Free Software Foundation, Inc.
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
> +
> +# Verify 'info variables|functions'
> +#    shows minimal symbols when no type matching is requested
> +#    does not show minimal symbols when type matching is requested.
> +
> +set testfile info_minsym
> +
> +standard_testfile info_minsym.c
> +
> +# Compile the program without debugging information, to have minimal symbols.
> +if {[prepare_for_testing "failed to prepare" $testfile $srcfile {c}]} {
> +    return -1
> +}
> +
> +clean_restart ${testfile}
> +
> +gdb_test_no_output "info variables -q -t int minsym" "minsym variables do not match type"
> +gdb_test_no_output "info functions -q -t int minsym" "minsym functions do not match type"
> +
> +gdb_test "info variables -q minsym" ".* minsym_var" "minsym variables found"
> +gdb_test "info functions -q minsym" ".* minsym_fun" "minsym functions found"

Perhaps you could tighten down the regex a bit.  For example if the commands wrongfully print
more than one result, but the output ends with minsym_var/minsym_fun, it won't be caught.
This should work:

gdb_test "info variables -q minsym" "$hex  minsym_var" "minsym variables found"
gdb_test "info functions -q minsym" "$hex  minsym_fun" "minsym functions found"

Otherwise, the test LGTM.

Simon