This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Use std::forward_list for displaced_step_inferior_states

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Kevin Buettner <kevinb at redhat dot com>
Cc: gdb-patches at sourceware dot org, Simon Marchi <simon dot marchi at ericsson dot com>
Date: Mon, 19 Nov 2018 11:58:46 -0500
Subject: Re: [PATCH] Use std::forward_list for displaced_step_inferior_states
References: <20181112185945.24599-1-simon.marchi@ericsson.com> <20181118115650.7731e488@pinnacle.lan>

On 2018-11-18 13:56, Kevin Buettner wrote:

On Mon, 12 Nov 2018 19:00:03 +0000
Simon Marchi <simon.marchi@ericsson.com> wrote:

Use std::forward_list instead of manually implemented list.  This
simplifies a bit the code, especially around removal.

Regtested on the buildbot.  There are some failures as always, but I
think they are unrelated.

gdb/ChangeLog:

	* infrun.c (displaced_step_inferior_states): Change type to
	std::forward_list.
	(get_displaced_stepping_state): Adjust.
	(displaced_step_in_progress_any_inferior): Adjust.
	(add_displaced_stepping_state): Adjust.
	(remove_displaced_stepping_state): Adjust.


LGTM.

Kevin


Thanks, I pushed it.

Simon

References:
- [PATCH] Use std::forward_list for displaced_step_inferior_states
  - From: Simon Marchi
- Re: [PATCH] Use std::forward_list for displaced_step_inferior_states
  - From: Kevin Buettner

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]