Re: Breakage on builder NetBSD-x86_64-m64, revision 970d89d8fdd84b31decaf3bd84e785aad057ea32

[Kamil Rytarowski <n54 at gmx dot com>]

On 20.11.2018 18:04, gdb-buildbot@sergiodj.net wrote:
> Unfortunately it seems that there is a breakage on GDB.
> 
> Commit title: 'Avoid "Invalid parameter passed to C runtime function" warning'
> Revision: 970d89d8fdd84b31decaf3bd84e785aad057ea32
> 
> You can find more details below:
> 
> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> 
> Buildslave:
> 	gdb-amd64-netbsd7
> 
> Full Build URL:
> 	<http://gdb-build.sergiodj.net/builders/NetBSD-x86_64-m64/builds/5846>
> 
> Commit(s) tested:
> 	970d89d8fdd84b31decaf3bd84e785aad057ea32
> 
> Author(s) (in the same order as the commits):
> 	Eli Zaretskii <eliz@gnu.org>
> 
> Subject:
> 	Avoid "Invalid parameter passed to C runtime function" warning
> 
> Testsuite log (gdb.sum and gdb.log) URL(s):
> 	<http://gdb-build.sergiodj.net/results/NetBSD-x86_64-m64/97/970d89d8fdd84b31decaf3bd84e785aad057ea32/>
> 
> *** Failed to compiled GDB.  ***
> ============================
> 
> +++ The full log is too big to be posted here.
> +++ These are the last 100 lines of it.
> 
>   CC       glob.o
>   CC       memmem.o
>   CC       mempcpy.o
>   CC       openat-proc.o
>   CC       rawmemchr.o
>   CC       rename.o
>   CC       secure_getenv.o
>   CC       strerror.o
>   CC       strerror-override.o
>   CC       strstr.o
>   AR       libgnu.a
>   GEN      charset.alias
>   GEN      ref-add.sed
>   GEN      ref-del.sed
> gmake[8]: Leaving directory '/home/motusgdb/motus/netbsd-x86_64/build/gdb/build-gnulib/import'
> gmake[7]: Leaving directory '/home/motusgdb/motus/netbsd-x86_64/build/gdb/build-gnulib/import'
> gmake[6]: Leaving directory '/home/motusgdb/motus/netbsd-x86_64/build/gdb/build-gnulib/import'
> gmake[5]: Leaving directory '/home/motusgdb/motus/netbsd-x86_64/build/gdb/build-gnulib'
> gmake[4]: Leaving directory '/home/motusgdb/motus/netbsd-x86_64/build/gdb/build-gnulib'
> gmake[3]: Leaving directory '/home/motusgdb/motus/netbsd-x86_64/build/gdb'
>   CXX    gdb.o
>   YACC   ada-exp.c
>   CXX    ada-exp.o
>   CXX    ada-lang.o
>   CXX    ada-tasks.o
>   CXX    ada-typeprint.o
>   CXX    ada-valprint.o
>   CXX    ada-varobj.o
>   CXX    addrmap.o
>   CXX    agent.o
>   CXX    amd64-bsd-nat.o
>   CXX    amd64-nat.o
>   CXX    amd64-nbsd-nat.o
>   CXX    amd64-nbsd-tdep.o
>   CXX    amd64-tdep.o
>   CXX    annotate.o
>   CXX    arch-utils.o
>   CXX    arch/amd64.o
>   CXX    arch/i386.o
>   CXX    auto-load.o
>   CXX    auxv.o
>   CXX    ax-gdb.o
>   CXX    ax-general.o
>   CXX    bcache.o
>   CXX    bfd-target.o
>   CXX    block.o
>   CXX    blockframe.o
>   CXX    break-catch-sig.o
>   CXX    break-catch-syscall.o
>   CXX    break-catch-throw.o
>   CXX    breakpoint.o
>   CXX    btrace.o
>   CXX    build-id.o
>   CXX    buildsym-legacy.o
>   CXX    buildsym.o
>   YACC   c-exp.c
> /home/motusgdb/motus/netbsd-x86_64/build/gdb/../../binutils-gdb/gdb/c-exp.y: warning: 42 shift/reduce conflicts [-Wconflicts-sr]
> /home/motusgdb/motus/netbsd-x86_64/build/gdb/../../binutils-gdb/gdb/c-exp.y: warning: 53 reduce/reduce conflicts [-Wconflicts-rr]
>   CXX    c-exp.o
>   CXX    c-lang.o
>   CXX    c-typeprint.o
>   CXX    c-valprint.o
>   CXX    c-varobj.o
>   CXX    charset.o
>   CXX    cli-out.o
>   CXX    cli/cli-cmds.o
>   CXX    cli/cli-decode.o
>   CXX    cli/cli-dump.o
>   CXX    cli/cli-interp.o
>   CXX    cli/cli-logging.o
>   CXX    cli/cli-script.o
>   CXX    cli/cli-setshow.o
>   CXX    cli/cli-utils.o
>   CXX    coff-pe-read.o
>   CXX    coffread.o
>   CXX    common/agent.o
>   CXX    common/btrace-common.o
>   CXX    common/buffer.o
>   CXX    common/cleanups.o
>   CXX    common/common-debug.o
>   CXX    common/common-exceptions.o
>   CXX    common/common-regcache.o
>   CXX    common/common-utils.o
>   CXX    common/environ.o
>   CXX    common/errors.o
>   CXX    common/fileio.o
>   CXX    common/filestuff.o
> ../../binutils-gdb/gdb/common/filestuff.c: In function 'gdb_file_up gdb_fopen_cloexec(const char*, const char*)':
> ../../binutils-gdb/gdb/common/filestuff.c:306:36: error: 'O_NOINHERIT' was not declared in this scope
>      O_CLOEXEC == 0 || O_CLOEXEC == O_NOINHERIT;
>                                     ^
> Makefile:1624: recipe for target 'common/filestuff.o' failed
> gmake[2]: Leaving directory '/home/motusgdb/motus/netbsd-x86_64/build/gdb'
> Makefile:8791: recipe for target 'all-gdb' failed
> gmake[2]: *** [common/filestuff.o] Error 1
> gmake[1]: *** [all-gdb] Error 2
> gmake[1]: Leaving directory '/home/motusgdb/motus/netbsd-x86_64/build'
> Makefile:848: recipe for target 'all' failed
> gmake: *** [all] Error 2
> ============================
> 

O_NOINHERIT is not available on NetBSD.

Please use: #ifdef O_NOINHERIT #endif for your code.

Attachment: signature.asc
Description: OpenPGP digital signature