This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[FYI] Remove obsolete comments from field_fmt
- From: Tom Tromey <tom at tromey dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tom at tromey dot com>
- Date: Sun, 25 Nov 2018 15:35:42 -0700
- Subject: [FYI] Remove obsolete comments from field_fmt
This removes some comments that I believe were made obsolete by the
recent change to cli_ui_out::do_field_fmt. The comment in mi_ui_out
probably was just copy/paste, because I think aligning never made
sense in an MI context.
gdb/ChangeLog
2018-11-25 Tom Tromey <tom@tromey.com>
* ui-out.c (ui_out::field_fmt): Remove comment.
* tui/tui-out.c (tui_ui_out::do_field_fmt): Remove comment.
* mi/mi-out.c (mi_ui_out::do_field_fmt): Remove comment.
---
gdb/ChangeLog | 6 ++++++
gdb/mi/mi-out.c | 2 --
gdb/tui/tui-out.c | 2 --
gdb/ui-out.c | 1 -
4 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/gdb/mi/mi-out.c b/gdb/mi/mi-out.c
index ea39fe29a1..39b18b03a0 100644
--- a/gdb/mi/mi-out.c
+++ b/gdb/mi/mi-out.c
@@ -124,8 +124,6 @@ mi_ui_out::do_field_string (int fldno, int width, ui_align align,
fprintf_unfiltered (stream, "\"");
}
-/* This is the only field function that does not align. */
-
void
mi_ui_out::do_field_fmt (int fldno, int width, ui_align align,
const char *fldname, const char *format,
diff --git a/gdb/tui/tui-out.c b/gdb/tui/tui-out.c
index 40f736fcb2..6d4e2363f3 100644
--- a/gdb/tui/tui-out.c
+++ b/gdb/tui/tui-out.c
@@ -71,8 +71,6 @@ tui_ui_out::do_field_string (int fldno, int width, ui_align align,
cli_ui_out::do_field_string (fldno, width, align, fldname, string);
}
-/* This is the only field function that does not align. */
-
void
tui_ui_out::do_field_fmt (int fldno, int width, ui_align align,
const char *fldname, const char *format,
diff --git a/gdb/ui-out.c b/gdb/ui-out.c
index ebe0285b49..3d74f78543 100644
--- a/gdb/ui-out.c
+++ b/gdb/ui-out.c
@@ -523,7 +523,6 @@ ui_out::field_fmt (const char *fldname, const char *format, ...)
int width;
ui_align align;
- /* Will not align, but has to call anyway. */
verify_field (&fldno, &width, &align);
va_start (args, format);
--
2.17.2