This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCHv2 2/3] gdb/regcache: When saving, ignore registers that can't be read

From: Pedro Alves <palves at redhat dot com>
To: Andrew Burgess <andrew dot burgess at embecosm dot com>
Cc: gdb-patches at sourceware dot org, Simon Marchi <simark at simark dot ca>
Date: Tue, 27 Nov 2018 16:57:29 +0000
Subject: Re: [PATCHv2 2/3] gdb/regcache: When saving, ignore registers that can't be read
References: <cover.1543317060.git.andrew.burgess@embecosm.com> <1fdb87a3328423d35fda3d45bdf54fa11bb8d82c.1543317060.git.andrew.burgess@embecosm.com> <130a11fc-540f-6393-7665-f3f047561887@redhat.com> <20181127153008.GG2834@embecosm.com>

On 11/27/2018 03:30 PM, Andrew Burgess wrote:

> Thanks for taking the time to review this patch.
> 
> Just wanted to confirm that (subject to review) the above feedback
> doesn't prevent patch #1 or #3 being merged, correct?

Correct.

> Patch #1 specifically makes the inferior call error rather than
> assert, which feels like it doesn't raise the same concerns you
> discuss above.
Absolutely.

Thanks,
Pedro Alves

References:
- [PATCHv2 0/3] Handle Errors While Preparing For Inferior Call
  - From: Andrew Burgess
- [PATCHv2 2/3] gdb/regcache: When saving, ignore registers that can't be read
  - From: Andrew Burgess
- Re: [PATCHv2 2/3] gdb/regcache: When saving, ignore registers that can't be read
  - From: Pedro Alves
- Re: [PATCHv2 2/3] gdb/regcache: When saving, ignore registers that can't be read
  - From: Andrew Burgess

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]