This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PUSHED/OBVIOUS] Re-fix leak in source.c (open_source_file).
On Thu, 2018-11-29 at 11:12 -0700, Tom Tromey wrote:
> > > > > > "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
>
> Philippe> Leak fixed in '8e6a5953e1d Fix 4K leak in open_source_file' has been partially
> Philippe> undone by '2179fbc36d23 Return scoped_fd from open_source_file'. Re-add the
> Philippe> transfer of current s->fullname to the unique_xmalloc_ptr fullname given to
> Philippe> find_and_open_source.
>
> Sorry about that, and thank you for fixing it.
No problem.
Note that after having run all GDB tests under valgrind, I still
see some 4K leaks in open_source_file appearing (I suspect)
when GDB reloads an executable that has changed.
Philippe