Re: [PUSHED/OBVIOUS] Re-fix leak in source.c (open_source_file).

[Tom Tromey <tom at tromey dot com>]

>>>>> "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:

>> What are the leaks?  I wonder if the "fullname"s in the psymtabs aren't
>> being freed.

Philippe> Yes, the 4K leak is the fullname (but fullname is freed now in all tests
Philippe> except in the 4 below tests, which all have something to do with reloading
Philippe> an executable/reload symbols ...

I thought I sent a reply to this yesterday but I don't see it now.

My first guess is that reread_symbols isn't calling
forget_cached_source_info_for_objfile.  Ages ago Jan had a patch to make
reread_symbols just do a delete+new for the objfile, rather than trying to 
do a brain transplant on the object.  That still seems like a good idea,
for this sort of reason.

However, once my psymtab series lands, it seems nicer to just move this
logic into the psymtab holder object.  This should fix the bug as well.

Tom