This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC/PATCH] Fix dwarf2read.c:dwarf2_find_containing_comp_unit's binary search
- From: Tom Tromey <tom at tromey dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Keith Seitz <keiths at redhat dot com>, Tom Tromey <tom at tromey dot com>, Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Date: Fri, 30 Nov 2018 10:52:20 -0700
- Subject: Re: [RFC/PATCH] Fix dwarf2read.c:dwarf2_find_containing_comp_unit's binary search
- References: <20181130172148.18830-1-sergiodj@redhat.com>
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> https://bugzilla.redhat.com/show_bug.cgi?id=1613614
Sergio> * dwarf2read.c (dwarf2_find_containing_comp_unit): Add
Sergio> 'mid_cu->length' to '*cu_off' when checking if 'sect_off' is
Sergio> inside the CU.
Thanks for the extensive analysis.
I agree this is correct; please check this in.
It's weird that cu_off is a pointer in this code.
It seems like that local could be removed entirely.
But, no need to do that in this patch.
Tom