This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [gdb/testsuite] Add gdb-caching-proc.exp testcase
- From: Tom Tromey <tom at tromey dot com>
- To: Tom de Vries <tdevries at suse dot de>
- Cc: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Fri, 30 Nov 2018 12:49:29 -0700
- Subject: Re: [gdb/testsuite] Add gdb-caching-proc.exp testcase
- References: <20181004174015.GA20307@delia> <dafc5935-4ae1-cd79-5adb-7cb13dd23aa5@redhat.com> <20181009134747.GA1742@delia>
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> 2018-10-09 Tom de Vries <tdevries@suse.de>
Tom> * gdb.base/gdb-caching-proc.exp: New file.
Thanks for the patch. I didn't see a review or see this go in, so
hopefully this isn't redundant.
Tom> +# Test gdb_caching_proc NAME
Tom> +proc test_proc { name } {
Tom> + set real_name gdb_real__$name
Tom> +
Tom> + set first [$real_name]
Tom> + lappend resultlist $first
I think this lappend is unnecessary...
Tom> + set resultlist [list]
... because resultlist is reset here.
But maybe you intended to hoist this earlier?
Either way is fine by me.
This is ok with this nit addressed.
Tom