Re: [RFC PATCH] Introduce dwarf2_cu::get_builder

[Tom Tromey <tom at tromey dot com>]

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> This patch is an attempt to deal with a variety of bugs reported where
Keith> GDB segfaults attempting to access a dwarf2_cu's builder.  In certain
Keith> circumstances, this builder can be NULL.

I think it would be good to describe one such case in the commit
message.  I suppose there must be some spot that works on an inherited
DIE in the context of its own CU?  I found myself wondering where.

Keith> I'm submitting this as an RFC rather than an actual patch because of the
Keith> lack of coverage testing for all the places where get_builder() is used.

I wouldn't be surprised if some of them aren't really reachable in the
sense of ever being able to take the ancestor path.  I'm not concerned
about needing tests for every single point.

Keith> +# This tests a segfault that occurs when reading inline_subroutine DIEs

inlined_subroutine (missing the "d")

Keith> +# bugzila mentioned above.  For clarity, some "superfluous" DIES have

Missing an "l" in bugzilla.

The rest seems good to me.  Thank you for the patch, and for reducing
and rewriting the test case like this.

Tom