This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Merge forward-search/reverse-search, use gdb::def_vector, remove limit (Re: [RFA] Fix leak in forward-search)


>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro>   -/* FIXME!!!  We walk right off the end of buf if we get a long line!!! */

I'm surprised all those exclamation marks didn't help us find this
sooner.  /s

Pedro> I don't think there's much point in reusing the buffer across
Pedro> command invocations.

Agreed.

Pedro> -  msg = (char *) re_comp (regex);
Pedro> +  char *msg = (char *) re_comp (regex);

Pre-existing, but I wonder why this cast is needed.  I think "const char
*msg" and removing the cast ought to be completely fine.  Or (more work)
avoid re_comp and use compiled_regex instead.

The rest seems fine to me.   Thank you for doing this.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]