This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 5/5] gdb/23712: Test case for multidictionary


>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> This is a test derived from one of the reproducers in symtab/23010.
Keith> The DIE tree used here is typical of compilations with LTO, where an
Keith> artificial parent DIE of language C99 imports DIEs of other languages.

Keith> testsuite/ChangeLog:

Keith> 	PR gdb/23712
Keith> 	* gdb.dwarf2/multidictionary.exp: New file.

Thanks.  This is great.

Keith> +# We force the DIEs above to be read in via "--readnow".
Keith> +set saved_gdbflags $GDBFLAGS
Keith> +append GDBFLAGS " --readnow"
Keith> +
Keith> +if {[prepare_for_testing "failed to prepare" $testfile \
Keith> +        "${asm_file} ${srcfile}" {}]} {
Keith> +    return -1
Keith> +}
Keith> +set GDBFLAGS $saved_gdbflags

I recently learned about gdb_spawn_with_cmdline_opts -- see
gdb.base/warning.exp for an example.  I think that's preferable to
saving and resetting GDBFLAGS.

This is ok with that change.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]