This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Use separate sed expressions to escape auto-load directories.
- From: Kevin Buettner <kevinb at redhat dot com>
- To: John Baldwin <jhb at FreeBSD dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 1 Dec 2018 17:25:57 -0700
- Subject: Re: [PATCH v2] Use separate sed expressions to escape auto-load directories.
- References: <20181201001057.43261-1-jhb@FreeBSD.org>
On Fri, 30 Nov 2018 16:10:57 -0800
John Baldwin <jhb@FreeBSD.org> wrote:
> Not all sed implementations support alternation via \| in the default
> regular expressions. Instead, resort to separate sed expressions via
> -e for $debugdir and $datadir. This fixes the default setting of the
> auto-load directories on FreeBSD. Previously on FreeBSD the sed
> invocation was a no-op causing the debugdir and datadir values to be
> expanded yielding an autoload path of ':${prefix}/share/gdb'.
>
> gdb/ChangeLog:
>
> * configure: Re-generate.
> * configure.ac: Use separate sed expressions to escape variables
> in auto-load directories.
I was more than a little surprised to find out that some (modern?)
versions of sed do not support alternation. But after logging into my
FreeNAS box (running FreeBSD 11), I see that this is so.
Your patch looks reasonable to me.
Kevin