This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Merge forward-search/reverse-search, use gdb::def_vector, remove limit (Re: [RFA] Fix leak in forward-search)
- From: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Sun, 02 Dec 2018 17:57:12 +0100
- Subject: Re: [PATCH] Merge forward-search/reverse-search, use gdb::def_vector, remove limit (Re: [RFA] Fix leak in forward-search)
- References: <20181127233328.5164-1-philippe.waroquiers@skynet.be> <3cf960b8-ff82-0670-fa90-c94d78573bfe@redhat.com> <1543532723.4149.7.camel@skynet.be> <6e8a2a00-bcbd-cdc6-f332-f59988bb8c40@redhat.com>
On Fri, 2018-11-30 at 19:43 +0000, Pedro Alves wrote:
> I looked a little and found that we do indeed have tests, however
> they test using the "search" alias, instead of "forward-search",
> which made them invisible to greps for the latter.
>
> I also noticed a couple other things... See the patch below. WDYT?
Looks much better than the previous code, and as expected, no
leaks there ...
So, FWIW, patch looks good to me ...
Philippe