This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Merge forward-search/reverse-search, use gdb::def_vector, remove limit (Re: [RFA] Fix leak in forward-search)


On Fri, 2018-11-30 at 19:43 +0000, Pedro Alves wrote:
> I looked a little and found that we do indeed have tests, however
> they test using the "search" alias, instead of "forward-search",
> which made them invisible to greps for the latter.
> 
> I also noticed a couple other things...  See the patch below.  WDYT?
Looks much better than the previous code, and as expected, no
leaks there ...

So, FWIW, patch looks good to me ...

Philippe


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]