This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 3/7] Fortran: Accessing fields of inherited types via fully qualified name.
- From: Richard Bunt <Richard dot Bunt at arm dot com>
- To: Paweł Wódkowski <pwodkowski at pl dot sii dot eu>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Thu, 6 Dec 2018 15:02:52 +0000
- Subject: Re: [PATCH v2 3/7] Fortran: Accessing fields of inherited types via fully qualified name.
- References: <1542663530-140490-1-git-send-email-pwodkowski@pl.sii.eu> <1542663530-140490-3-git-send-email-pwodkowski@pl.sii.eu> <88ec6786-8834-7da2-207a-7392fd657e41@arm.com> <53cac622aea64147b2c1cd25feb16bdd@pl.sii.eu>
Hi Paweł,
I was testing with gfortran 7.3.0 and ifort 18.2. On the latter I observe
2 kfails relating to the missing extends in the ptype output. However, this
is because I do not have patch 4 applied. I will take a closer look at this
patch with ifort 18.2 since I can analyze the implementation in action.
On 12/4/18 9:05 PM, Paweł Wódkowski wrote:
>>> +gdb_test "whatis wp_vla" "type = <not allocated>"
A small nit while I'm here:
GDB tests needs to be uniquely identifiable, see https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique
1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: continue to breakpoint: ! After value assignment
1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: continue to breakpoint: ! Before vla allocation
1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: ptype wp%point%coo
1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: ptype wp_vla(1)%point%coo
1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp
1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp%point
1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp%point%coo
1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)
1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)%point
1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)%point%coo
1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: whatis wp
2 (gdb) PASS: gdb.fortran/oop-extend-type.exp: whatis wp_vla
Many thanks,
Rich.